From: Andi Kleen <ak@muc.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, gregkh@suse.de,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [patch 2/2] Convert bigsmp to use flat physical mode
Date: 22 Nov 2005 09:56:12 +0100 [thread overview]
Date: Tue, 22 Nov 2005 09:56:12 +0100 [thread overview]
Message-ID: <20051122085612.GB9723@muc.de> (raw)
In-Reply-To: <20051121170411.A15347@unix-os.sc.intel.com>
On Mon, Nov 21, 2005 at 05:04:11PM -0800, Ashok Raj wrote:
> On Mon, Nov 21, 2005 at 03:39:16PM -0800, Ashok Raj wrote:
> >
> > - if ((num_processors > 8) &&
> > - APIC_XAPIC(ver) &&
> > - (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL))
> > + if (APIC_XAPIC(ver) &&
> > + (CPU_HOTPLUG_ENABLED ||
> > + ((num_processors > 8) &&
> > + (boot_cpu_data.x86_vendor ==
> > X86_VENDOR_INTEL))))
> > def_to_bigsmp = 1;
>
> Noticed that Andi send one more patch do enable bigsmp for AMD (i386), and the
> APIC_XAPIC() check was not properly placed to factor this in. This updated
> patch should work for AMD as well, and switch to bigsmp when we have hotplug
> enabled.
Looks good thanks.
-Andi
next prev parent reply other threads:[~2005-11-22 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 23:39 [patch 0/2] " Ashok Raj
2005-11-21 23:39 ` [patch 1/2] " Ashok Raj
2005-11-21 23:39 ` [patch 2/2] " Ashok Raj
2005-11-22 1:04 ` Ashok Raj
2005-11-22 8:56 ` Andi Kleen [this message]
2005-11-23 4:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122085612.GB9723@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®