mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: arjan@infradead.org
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	rmk@arm.linux.org.uk, torvalds@osdl.org, ak@muc.de
Subject: Re: [NET]: Shut up warnings in net/core/flow.c
Date: Wed, 23 Nov 2005 13:24:40 -0800 (PST)	[thread overview]
Message-ID: <20051123.132440.71355611.davem@davemloft.net> (raw)
In-Reply-To: <1132737084.2795.20.camel@laptopd505.fenrus.org>

From: Arjan van de Ven <arjan@infradead.org>
Date: Wed, 23 Nov 2005 10:11:24 +0100

> it can.. but only if we start using -ffunction-sections in the CFLAGS
> (or make all of these functions static I suppose and reenable
> -funit-at-a-time, which can be done for gcc 4.x only)

I actually just scanned the tree, and outside of files that
only get built on CONFIG_SMP (namely, arch/${ARCH}/kernel/smp{,boot}.c)
the IPI functions were %99 marked static already and the remaining
%1 should be marked static.  The cases in that %1 group are:

arch/mips/sibyte/sb1250/prom.c:prom_cpu0_exit()
arch/powerpc/kernel/machine_kexec_64.c:kexec_smp_down()

And as stated, those two can just be marked static right now.

So we could very easily remove the CONFIG_SMP ifdefs, but the
-funit-at-a-time requirement to get gcc to not emit unused static
functions is very unfortunate.

Even tricks like marking the IPI function "inline" don't work since
we're taking the address of the function.

  reply	other threads:[~2005-11-23 21:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200511230159.jAN1xeMl003154@hera.kernel.org>
2005-11-23  8:21 ` Andrew Morton
2005-11-23  8:55   ` David S. Miller
2005-11-23  9:11     ` Arjan van de Ven
2005-11-23 21:24       ` David S. Miller [this message]
2005-11-23 21:28         ` Arjan van de Ven
2005-11-23 22:02           ` David S. Miller
2005-11-23 16:54     ` Linus Torvalds
2005-11-23 23:20       ` David S. Miller
2005-11-23 23:29         ` Linus Torvalds
2005-11-24  0:53           ` David S. Miller
2005-11-24  7:46           ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051123.132440.71355611.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®