From: Pavel Machek <pavel@ucw.cz>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH] split sharpsl_pm.c into generic and corgi/spitz specific parts
Date: Wed, 23 Nov 2005 20:49:27 +0100 [thread overview]
Message-ID: <20051123194927.GA22375@elf.ucw.cz> (raw)
In-Reply-To: <1132754229.8016.55.camel@localhost.localdomain>
Hi!
> > I'd like to see it applied...
>
> This diff looks much neater than the last one and I agree with the
> principle of it. I don't think its the right time to apply it for two
> reasons:
>
> 1. We probably shouldn't (can't?) make changes like this in -rc
> kernels
No, it does not really belong in -rc. I was hoping you would merge it
in your tree so I do not have big patch here and could keep only
collie changes...
> I have a proposal for how we proceed with this:
>
> After 2.6.15 is released, I envisage a patch which splits the common
> sections of sharpsl_pm.c into arm/common and arm/mach-pxa/sharpsl.h into
> include/arm/hardware/sharpsl_pm.h. I'm happy to generate that patch if
> necessary and pass it to Russell. I'll try and create a patch to show
> the structure I'm aiming for in the next couple of days but at the
> moment we don't know exactly which code is common and I'd prefer to try
> and do the split in one go.
Ok, works for me. So I'll now concentrate on getting collie working
and leave infrastructure to you...
> I did note your patch adds a copyright header to a file you're mostly
> deleting code from?
I actually did add some collie parts into it, and then deleted
everything #ifdef collie from that. Sorry.
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2005-11-23 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 13:03 Pavel Machek
2005-11-23 13:57 ` Richard Purdie
2005-11-23 19:49 ` Pavel Machek [this message]
2005-11-23 20:16 ` Richard Purdie
2005-11-23 21:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123194927.GA22375@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®