From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: bunk@stusta.de, rdunlap@xenotime.net, arjan@infradead.org,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
Date: Wed, 23 Nov 2005 21:05:14 -0800 [thread overview]
Message-ID: <20051123210514.1cb5888e.akpm@osdl.org> (raw)
In-Reply-To: <20051124042150.GC30849@redhat.com>
Dave Jones <davej@redhat.com> wrote:
>
> On Wed, Nov 23, 2005 at 11:54:40PM +0100, Adrian Bunk wrote:
> > On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote:
> > > On Wed, 23 Nov 2005, Adrian Bunk wrote:
> > >
> > > > Every inline dummy function should be static.
> > >
> > > Please explain why it matters in this case.
> >
> > We don't need an additional global copy of the function.
>
> it's an empty body, surely the compiler will compile it away ?
>
With
inline void foo(void)
{
}
The compiler has to put an out-of-line copy of foo() into this .o file in
case some other .o file calls it.
next prev parent reply other threads:[~2005-11-24 5:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 11:35 2.6.15-rc2-mm1 Andrew Morton
2005-11-23 13:35 ` 2.6.15-rc2-mm1 Serge E. Hallyn
2005-11-23 14:15 ` 2.6.15-rc2-mm1 Michal Piotrowski
2005-11-23 19:22 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 9:04 ` 2.6.15-rc2-mm1 Harald Welte
2005-11-23 14:24 ` 2.6.15-rc2-mm1 thunder7
2005-11-23 17:50 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 19:33 ` 2.6.15-rc2-mm1 Ian McDonald
2005-11-23 19:50 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 20:12 ` 2.6.15-rc2-mm1 Greg KH
2005-11-23 20:23 ` 2.6.15-rc2-mm1 Marc Koschewski
2005-11-23 19:38 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 2:06 ` Mouse issues in -mm Frank Sorenson
2005-11-24 3:26 ` Dmitry Torokhov
2005-11-24 6:14 ` Frank Sorenson
2005-11-25 22:31 ` Dmitry Torokhov
2005-11-24 9:40 ` Marc Koschewski
2005-11-25 22:27 ` Dmitry Torokhov
2005-11-26 2:52 ` Marc Koschewski
2005-11-26 3:50 ` Dmitry Torokhov
2005-11-23 20:25 ` 2.6.15-rc2-mm1 Benoit Boissinot
2005-11-23 22:35 ` [-mm patch] init/main.c: dummy mark_rodata_ro() should be static Adrian Bunk
2005-11-23 22:46 ` Randy.Dunlap
2005-11-23 22:54 ` Adrian Bunk
2005-11-24 4:21 ` Dave Jones
2005-11-24 5:05 ` Andrew Morton [this message]
2005-11-24 5:06 ` Adrian Bunk
2005-11-24 5:14 ` [-mm patch] " Adrian Bunk
2005-11-24 7:56 ` Arjan van de Ven
2005-11-25 15:49 ` Adrian Bunk
2005-11-24 7:56 ` [-mm patch] init/main.c: " Arjan van de Ven
2005-11-24 0:20 ` 2.6.15-rc2-mm1 J.A. Magallon
2005-11-24 0:27 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-24 3:18 ` 2.6.15-rc2-mm1 KAMEZAWA Hiroyuki
2005-11-24 5:02 ` 2.6.15-rc2-mm1 Andrew Morton
2005-11-25 13:36 ` [PATCH] oprofile : Use vmalloc_node() in alloc_cpu_buffers() Eric Dumazet
2005-11-24 18:48 ` 2.6.15-rc2-mm1 Alexandre Buisse
2005-11-26 5:49 ` 2.6.15-rc2-mm1 Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123210514.1cb5888e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®