From: Andrew Morton <akpm@osdl.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: benh@kernel.crashing.org, mbuesch@freenet.de,
david-b@pacbell.net, greg@kroah.com,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: Latest GIT: USB ehci_hcd broken (spinlock corruption)
Date: Sun, 27 Nov 2005 16:59:09 -0800 [thread overview]
Message-ID: <20051127165909.15be4d7f.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0511271654280.16475-100000@netrider.rowland.org>
Alan Stern <stern@rowland.harvard.edu> wrote:
>
> For now, you can workaround the bug by adding:
>
> spin_lock_init(&ehci_lock);
>
> as the first line of drivers/usb/host/ehci-pci.c:ehci_pci_reset().
Yup.
--- devel/drivers/usb/host/ehci-pci.c~gregkh-usb-usb-pm-09-fix 2005-11-25 19:03:59.000000000 -0800
+++ devel-akpm/drivers/usb/host/ehci-pci.c 2005-11-25 19:03:59.000000000 -0800
@@ -129,6 +129,8 @@ static int ehci_pci_reset(struct usb_hcd
u32 temp;
int retval;
+ spin_lock_init(&ehci->lock);
+
ehci->caps = hcd->regs;
ehci->regs = hcd->regs + HC_LENGTH(readl(&ehci->caps->hc_capbase));
dbg_hcs_params(ehci, "reset");
_
next prev parent reply other threads:[~2005-11-28 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-27 11:34 Michael Buesch
2005-11-27 21:25 ` Benjamin Herrenschmidt
2005-11-27 22:06 ` Alan Stern
2005-11-28 0:59 ` Andrew Morton [this message]
2005-11-28 16:40 ` David Brownell
2005-11-28 22:07 ` Andrew Morton
2005-11-29 6:28 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051127165909.15be4d7f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mbuesch@freenet.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®