From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andries.Brouwer@cwi.nl
Cc: linux-kernel@vger.kernel.org
Subject: Re: s_maxbytes on isofs for 2.4
Date: Mon, 28 Nov 2005 11:46:43 -0200 [thread overview]
Message-ID: <20051128134643.GB25081@logos.cnet> (raw)
In-Reply-To: <200511272123.jARLNeA03057@apps.cwi.nl>
Hi Andries,
On Sun, Nov 27, 2005 at 10:23:40PM +0100, Andries.Brouwer@cwi.nl wrote:
> I got a problem report on the handling of large (2.4GB) files
> with isofs, where 2.6 was fine and 2.4 failed. Replied
>
> >I suspect that the difference between 2.4 and 2.6 is the assignment
> > s->s_maxbytes = 0xffffffff;
> >in isofs/inode.c. Could you try to add that after
> > s->s_magic = ISOFS_SUPER_MAGIC;
> >in the 2.4 source?
>
> and got the confirmation that that solves the problems.
> Maybe one should consider adding this in 2.4.
> No, I have not audited the source. If in fact there is
> a reason why files this size are not handled correctly,
> there should probably be an assignment with the largest
> value that is handled correctly, together with a comment.
My knowledge is quite limited, but I can't spot any issues with
files upto 4GB. Who was the reporter?
Yes, suppose we could include it if there is interest to confirm safety.
next prev parent reply other threads:[~2005-11-28 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-27 21:23 Andries.Brouwer
2005-11-28 13:46 ` Marcelo Tosatti [this message]
2005-11-28 20:33 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051128134643.GB25081@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®