mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>,
	linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] dpt_i2o fix for deadlock condition
Date: Tue, 29 Nov 2005 19:53:36 +0100	[thread overview]
Message-ID: <20051129185336.GJ31395@stusta.de> (raw)
In-Reply-To: <20051129180437.GB3803@csclub.uwaterloo.ca>

On Tue, Nov 29, 2005 at 01:04:37PM -0500, Lennart Sorensen wrote:
> On Tue, Nov 29, 2005 at 11:51:25AM -0500, Salyzyn, Mark wrote:
> > Miquel van Smoorenburg <miquels@cistron.nl> forwarded me this fix to
> > resolve a deadlock condition that occurs due to the API change in
> > 2.6.13+ kernels dropping the host locking when entering the error
> > handling. They all end up calling adpt_i2o_post_wait(), which if you
> > call it unlocked, might return with host_lock locked anyway and that
> > causes a deadlock.
> > 
> > Signed-off-by: Mark Salyzyn <aacraid@adaptec.com>
> > 
> >  drivers/scsi/dpt_i2o.c |    25 ++++++++++++++++++++-----
> >  1 file changed, 20 insertions(+), 5 deletions(-)
> > 
> > Patch attached to email due to Outlook corrupting content when inlined.
> 
> There must still be a way to tell outlook to make the type something
> useful, rather than application/octet-stream.  maybe if the extension
> was .patch.txt it would do something smarter.

Patches in Attachments aren't nice, but better than corrupted patches.

It's unfortunate, but bitching on the people who are somehow forced to 
use crappy email clients is IMHO not a good idea.

> Len Sorensen

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2005-11-29 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-29 16:51 Salyzyn, Mark
2005-11-29 18:04 ` Lennart Sorensen
2005-11-29 18:53   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051129185336.GJ31395@stusta.de \
    --to=bunk@stusta.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=mark_salyzyn@adaptec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®