From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750820AbVK3V0n (ORCPT ); Wed, 30 Nov 2005 16:26:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750800AbVK3V0n (ORCPT ); Wed, 30 Nov 2005 16:26:43 -0500 Received: from smtp.osdl.org ([65.172.181.4]:62925 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750778AbVK3V0m (ORCPT ); Wed, 30 Nov 2005 16:26:42 -0500 Date: Wed, 30 Nov 2005 13:27:57 -0800 From: Andrew Morton To: Franck Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Add MIPS dependency for dm9000 driver Message-Id: <20051130132757.36e1cca0.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Franck wrote: > > The attached patch adds MIPS dependency for dm9000 ethernet > controller. Indeed this controller is used by some embedded platforms > based on MIPS CPUs. > > Signed-Off-By: Franck Bui-Huu > --- > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index f15f909..1b00169 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -856,7 +856,7 @@ config SMC9194 > > config DM9000 > tristate "DM9000 support" > - depends on ARM && NET_ETHERNET > + depends on (ARM || MIPS) && NET_ETHERNET > select CRC32 > select MII Is there any reason why we cannot enable this driver on all architectures? It's moderately important for quality and maintainability reasons that it be included in the x86 build, at least..