From: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, ehabkost@mandriva.com
Subject: [PATCH 03/10] usb-serial: cyberjack driver port.
Date: Tue, 6 Dec 2005 09:58:55 -0200 [thread overview]
Message-ID: <20051206095855.080df3db.lcapitulino@mandriva.com.br> (raw)
Ports the cyberjack driver from write_urb_busy spin_lock to
usb_serial_write_urb_lock() functions.
Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>
drivers/usb/serial/cyberjack.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff -Nparu -X /home/lcapitulino/kernels/dontdiff a/drivers/usb/serial/cyberjack.c a~/drivers/usb/serial/cyberjack.c
--- a/drivers/usb/serial/cyberjack.c 2005-12-04 19:19:57.000000000 -0200
+++ a~/drivers/usb/serial/cyberjack.c 2005-12-04 19:25:50.000000000 -0200
@@ -215,14 +215,10 @@ static int cyberjack_write (struct usb_s
return (0);
}
- spin_lock(&port->lock);
- if (port->write_urb_busy) {
- spin_unlock(&port->lock);
+ if (usb_serial_write_urb_lock(port)) {
dbg("%s - already writing", __FUNCTION__);
return 0;
}
- port->write_urb_busy = 1;
- spin_unlock(&port->lock);
spin_lock_irqsave(&priv->lock, flags);
@@ -230,7 +226,7 @@ static int cyberjack_write (struct usb_s
/* To much data for buffer. Reset buffer. */
priv->wrfilled=0;
spin_unlock_irqrestore(&priv->lock, flags);
- port->write_urb_busy = 0;
+ usb_serial_write_urb_unlock(port);
return (0);
}
@@ -275,7 +271,7 @@ static int cyberjack_write (struct usb_s
priv->wrfilled=0;
priv->wrsent=0;
spin_unlock_irqrestore(&priv->lock, flags);
- port->write_urb_busy = 0;
+ usb_serial_write_urb_unlock(port);
return 0;
}
@@ -421,7 +417,7 @@ static void cyberjack_write_bulk_callbac
dbg("%s - port %d", __FUNCTION__, port->number);
- port->write_urb_busy = 0;
+ usb_serial_write_urb_unlock(port);
if (urb->status) {
dbg("%s - nonzero write bulk status received: %d", __FUNCTION__, urb->status);
return;
--
Luiz Fernando N. Capitulino
reply other threads:[~2005-12-06 12:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051206095855.080df3db.lcapitulino@mandriva.com.br \
--to=lcapitulino@mandriva.com.br \
--cc=ehabkost@mandriva.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®