From: Eduardo Pereira Habkost <ehabkost@mandriva.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH 01/10] usb-serial: URB write locking macros.
Date: Tue, 6 Dec 2005 10:46:22 -0200 [thread overview]
Message-ID: <20051206124621.GK13801@duckman.conectiva> (raw)
In-Reply-To: <1133871843.4836.15.camel@laptopd505.fenrus.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Tue, Dec 06, 2005 at 01:24:03PM +0100, Arjan van de Ven wrote:
> On Tue, 2005-12-06 at 09:57 -0200, Luiz Fernando Capitulino wrote:
> > Introduces URB write locking macros.
>
> ugh.. WHY ?
Maybe we need a better description for the patch: the locking is already
there (the 'lock' field in struct sub_serial_port), and there is no
change of behaviour, just replacing a (spin_lock_t, int) by an atomic_t.
The purpose of the changes is removing the spinlock, because it is used
only to protect write_urb_busy, and if someday we need locking on other
parts, we already have a semaphore (introduced by Capitulino some time
ago, to fix a open()/close() race condition).
--
Eduardo
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-12-06 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 11:57 Luiz Fernando Capitulino
2005-12-06 12:24 ` Arjan van de Ven
2005-12-06 12:37 ` Luiz Fernando Capitulino
2005-12-06 12:46 ` Eduardo Pereira Habkost [this message]
2005-12-06 12:35 ` [linux-usb-devel] " Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051206124621.GK13801@duckman.conectiva \
--to=ehabkost@mandriva.com \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®