From: Andrew Morton <akpm@osdl.org>
To: vatsa@in.ibm.com
Cc: paulmck@us.ibm.com, dipankar@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix RCU race in access of nohz_cpu_mask
Date: Wed, 7 Dec 2005 16:37:46 -0800 [thread overview]
Message-ID: <20051207163746.46248c73.akpm@osdl.org> (raw)
In-Reply-To: <20051205110239.GE2385@in.ibm.com>
Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
>
> + smp_mb();
> + cpus_andnot(rsp->cpumask, cpu_online_map, nohz_cpu_mask);
Please always include a comment when adding a barrier. Because it's often
not obvious to the reader what that barrier is actually doing.
next prev parent reply other threads:[~2005-12-08 0:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 11:02 Srivatsa Vaddagiri
2005-12-08 0:37 ` Andrew Morton [this message]
2005-12-08 19:31 Oleg Nesterov
2005-12-09 2:46 ` Srivatsa Vaddagiri
2005-12-09 19:17 ` Oleg Nesterov
2005-12-10 15:19 ` Srivatsa Vaddagiri
2005-12-10 18:55 ` Oleg Nesterov
2005-12-12 3:10 ` Paul E. McKenney
2005-12-12 4:32 ` Andrew Morton
2005-12-12 4:38 ` David S. Miller
2005-12-12 4:47 ` Nick Piggin
2005-12-12 4:49 ` Paul Mackerras
2005-12-12 6:27 ` Keith Owens
2005-12-09 2:56 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207163746.46248c73.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®