mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Keith Mannthey <kmannth@gmail.com>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
Date: Wed, 7 Dec 2005 18:46:41 +0100	[thread overview]
Message-ID: <20051207174640.GA11190@wotan.suse.de> (raw)
In-Reply-To: <43970136.4010006@cosmosbay.com>

On Wed, Dec 07, 2005 at 04:35:18PM +0100, Eric Dumazet wrote:
> As reported by Keith Mannthey, there are problems in populate_memnodemap()
> 
> The bug was that the compute_hash_shift() was returning 31, with incorrect 
> initialization of memnodemap[]
> 
> To correct the bug, we must use (1UL << shift) instead of (1 << shift) to 
> avoid an integer overflow, and we must check that shift < 64 to avoid an 
> infinite loop.

Thanks looks good.

I guess we'll need that for 2.6.15.

-Andi

  reply	other threads:[~2005-12-07 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a762e240512062124i517a9c35xd1ec681428418341@mail.gmail.com>
2005-12-07 15:35 ` Eric Dumazet
2005-12-07 17:46   ` Andi Kleen [this message]
2005-12-11 18:27   ` Andi Kleen
2005-12-12  8:34     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051207174640.GA11190@wotan.suse.de \
    --to=ak@suse.de \
    --cc=dada1@cosmosbay.com \
    --cc=kmannth@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome