From: Andrew Morton <akpm@osdl.org>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i386: CS5535 chip support - GPIO
Date: Fri, 9 Dec 2005 15:26:25 -0800 [thread overview]
Message-ID: <20051209152625.130641bb.akpm@osdl.org> (raw)
In-Reply-To: <808c8e9d0512070933re472072x43f35d454be699f1@mail.gmail.com>
Ben Gardner <gardner.ben@gmail.com> wrote:
>
> +/* These are defined in cs5535.c */
> +extern u32 cs5535_gpio_base;
> +extern u32 cs5535_gpio_mask;
And they should be declared in a header file, please.
Is there a reason for these being exported to non-GPL modules, or can they
be EXPORT_SYMBOL_GPL()?
prev parent reply other threads:[~2005-12-09 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 17:33 Ben Gardner
2005-12-09 23:26 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051209152625.130641bb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=gardner.ben@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®