From: Andi Kleen <ak@suse.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Andi Kleen <ak@suse.de>, Rohit Seth <rohit.seth@intel.com>,
Len Brown <len.brown@intel.com>
Subject: Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
Date: Fri, 9 Dec 2005 19:07:39 +0100 [thread overview]
Message-ID: <20051209180739.GH11190@wotan.suse.de> (raw)
In-Reply-To: <20051209095243.A22139@unix-os.sc.intel.com>
Just a quick comment - didn't review the full patch.
> +#ifdef ARCH_APICTIMER_STOPS_ON_C3
> + if (c->x86_vendor == X86_VENDOR_INTEL) {
> + on_each_cpu(switch_APIC_timer_to_ipi,
> + &mask, 1, 1);
> + }
> +#endif
Better make it a runtime variable instead of an ifdef with a boot option.
I found at least one non Intel system so far with the same issue
(although it wasn't multi processor)
-Andi
next prev parent reply other threads:[~2005-12-09 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 2:10 Venkatesh Pallipadi
2005-12-09 8:06 ` Zwane Mwaikambo
2005-12-09 12:49 ` Venkatesh Pallipadi
2005-12-09 17:35 ` Zwane Mwaikambo
2005-12-09 17:34 ` Andi Kleen
2005-12-09 17:52 ` Venkatesh Pallipadi
2005-12-09 18:07 ` Andi Kleen [this message]
2005-12-09 23:06 ` Venkatesh Pallipadi
2005-12-09 18:27 ` Zwane Mwaikambo
2005-12-13 1:47 ` [PATCH 0/3]i386,x86-64 (take 2) " Venkatesh Pallipadi
2005-12-13 3:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051209180739.GH11190@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rohit.seth@intel.com \
--cc=torvalds@osdl.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®