From: Andrew Morton <akpm@osdl.org>
To: Cornelia Huck <cornelia.huck@gmail.com>
Cc: schwidefsky@de.ibm.com, cohuck@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 15/17] s390: convert /proc/cio_ignore.
Date: Sat, 10 Dec 2005 01:37:30 -0800 [thread overview]
Message-ID: <20051210013730.2f932332.akpm@osdl.org> (raw)
In-Reply-To: <a070070d0512100130u592b3517y@mail.gmail.com>
Cornelia Huck <cornelia.huck@gmail.com> wrote:
>
> > Unneeded (and undesirable) cast of void*.
>
> Some people seem to prefer explicit casts to make the
> type more clear. Is there any concensus on this? (I don't care
> either way ;))
It's better to omit the casts because
a) they're ugly and
b) If someone changes the type of the RHS from void* to anything else,
we'll get a warning, probably leading us to a bug. The cast would have
prevented that warning. IOW, omitting the cast is more type-safe.
prev parent reply other threads:[~2005-12-10 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 15:29 Martin Schwidefsky
2005-12-10 7:53 ` Andrew Morton
2005-12-10 9:30 ` Cornelia Huck
2005-12-10 9:37 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051210013730.2f932332.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cohuck@de.ibm.com \
--cc=cornelia.huck@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®