From: Bao Zhao <baozhaolinuxer@yahoo.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: typo in debugfs code comments?
Date: Fri, 9 Dec 2005 23:50:12 -0800 (PST) [thread overview]
Message-ID: <20051210075012.87815.qmail@web31715.mail.mud.yahoo.com> (raw)
In-Reply-To: <20051210025720.GA17847@kroah.com>
--- Greg KH <greg@kroah.com> wrote:
> On Fri, Dec 09, 2005 at 06:01:34PM -0800, Bao Zhao
> wrote:
> > I think that the comments of debugfs_create_u16
> and
> > debugfs_create_u32
> > have the copy and paste error.
> >
> > below is original comments.
> > /**
> > * debugfs_create_u16 - create a file in the
> debugfs
> > filesystem that is used to read and write a
> unsigned 8
> > bit value.
> > *
> >
> > /**
> > * debugfs_create_u32 - create a file in the
> debugfs
> > filesystem that is used to read and write a
> unsigned 8
> > bit value.
> > *
> >
> > It should be "a unsigned 16 bit value" and "a
> unsigned
> > 32 bit value"
>
> Heh, cut and paste comments :)
>
> Care to send me a patch, as per
> Documentation/SubmittingPatches to fix
> this up?
>
> thanks,
>
> greg k-h
>
This patch fixes cut and paste error in debugfs.
Signed-off-by: Zhao Bao <baozhaolinuxer@yahoo.com>
---
--- linux-2.6.14.3/fs/debugfs/file.c.orig 2005-12-03
17:39:41.000000000 -0500
+++ linux-2.6.14.3/fs/debugfs/file.c 2005-12-03
17:41:15.000000000 -0500
@@ -98,7 +98,7 @@ static u64 debugfs_u16_get(void
*data)
DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get,
debugfs_u16_set, "%llu\n");
/**
- * debugfs_create_u16 - create a file in the debugfs
filesystem that is used to read and write a unsigned 8
bit value.
+ * debugfs_create_u16 - create a file in the debugfs
filesystem that is used to read and write a unsigned
16 bit value.
*
* @name: a pointer to a string containing the name
of the file to create.
* @mode: the permission that the file should have
@@ -140,7 +140,7 @@ static u64 debugfs_u32_get(void
*data)
DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get,
debugfs_u32_set, "%llu\n");
/**
- * debugfs_create_u32 - create a file in the debugfs
filesystem that is used to read and write a unsigned 8
bit value.
+ * debugfs_create_u32 - create a file in the debugfs
filesystem that is used to read and write a unsigned
32 bit value.
*
* @name: a pointer to a string containing the name
of the file to create.
* @mode: the permission that the file should have
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
next prev parent reply other threads:[~2005-12-10 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-10 2:01 Bao Zhao
2005-12-10 2:57 ` Greg KH
2005-12-10 7:50 ` Bao Zhao [this message]
2005-12-10 8:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051210075012.87815.qmail@web31715.mail.mud.yahoo.com \
--to=baozhaolinuxer@yahoo.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®