mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@osdl.org>,
	Jesper Juhl <jesper.juhl@gmail.com>
Subject: [-mm PATCH] EDAC: make Kconfig defaults match recommendations in help text
Date: Sun, 11 Dec 2005 14:16:05 +0100	[thread overview]
Message-ID: <200512111416.05501.jesper.juhl@gmail.com> (raw)

"config EDAC" and "config EDAC_MM_EDAC" both state clearly that if the user
is unsure she should select "Y", yet the default for those options is "N".

This patch brings the default for the options into line with the
recommendation stated in the help text.

Please consider for inclusion.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 drivers/edac/Kconfig |    2 ++
 1 files changed, 2 insertions(+)

diff -U 7 linux-2.6.15-rc5-mm2-orig/drivers/edac/Kconfig linux-2.6.15-rc5-mm2/drivers/edac/Kconfig
--- linux-2.6.15-rc5-mm2-orig/drivers/edac/Kconfig	2005-12-11 13:53:26.000000000 +0100
+++ linux-2.6.15-rc5-mm2/drivers/edac/Kconfig	2005-12-11 14:04:06.000000000 +0100
@@ -7,14 +7,15 @@
 #
 
 menu 'EDAC - error detection and reporting (RAS)'
 
 config EDAC
 	tristate "EDAC core system error reporting"
 	depends on X86
+	default y
 	help
 	  EDAC is designed to report errors in the core system.
 	  These are low-level errors that are reported in the CPU or
 	  supporting chipset: memory errors, cache errors, PCI errors,
 	  thermal throttling, etc..  If unsure, select 'Y'.
 
 
@@ -29,14 +30,15 @@
 	  sub-system. You can insert module with "debug_level=x", current
 	  there're four debug levels (x=0,1,2,3 from low to high).
 	  Usually you should select 'N'.
 
 config EDAC_MM_EDAC
 	tristate "Main Memory EDAC (Error Detection And Correction) reporting"
 	depends on EDAC
+	default y
 	help
 	  Some systems are able to detect and correct errors in main
 	  memory.  EDAC can report statistics on memory error
 	  detection and correction (EDAC - or commonly referred to ECC
 	  errors).  EDAC will also try to decode where these errors
 	  occurred so that a particular failing memory module can be
 	  replaced.  If unsure, select 'Y'.




                 reply	other threads:[~2005-12-11 13:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200512111416.05501.jesper.juhl@gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome