Re: [PATCH 6/6] per-mount noatime and nodiratime

[Andrew Morton <akpm@osdl.org>]

Christoph Hellwig <hch@lst.de> wrote:
>
> Turn noatime and nodiratime into per-mount instead of per-sb flags.
> 
> After all the preparations this is a rather trivial patch, touch_atime
> and nfs need to be changed to check the new location (and I've killed
> the IS_NOATIME/IS_NODIRATIME macros that were only used by touch_atime
> while we were at it), and the mount/remount code needed small changes
> to treat it correctly.
> 

Where'd this hunk come from?

> Index: linux-2.6.15-rc5/fs/super.c
> ===================================================================
> --- linux-2.6.15-rc5.orig/fs/super.c	2005-12-13 11:27:14.000000000 +0100
> +++ linux-2.6.15-rc5/fs/super.c	2005-12-13 12:06:00.000000000 +0100
> @@ -830,9 +830,9 @@
>  	mnt->mnt_parent = mnt;
>  
>  	if (type->fs_flags & FS_NOATIME)
> -		sb->s_flags |= MS_NOATIME;
> +		mnt->mnt_flags |= MNT_NOATIME;
>  	if (type->fs_flags & FS_NODIRATIME)
> -		sb->s_flags |= MS_NODIRATIME;
> +		mnt->mnt_flags |= MNT_NODIRATIME;
>  
>  	up_write(&sb->s_umount);
>  	free_secdata(secdata);

I just dropped it, but it's a worry...