From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Hugh Dickins <hugh@veritas.com>,
Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Badari Pulavarty <pbadari@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: set_page_dirty vs set_page_dirty_lock
Date: Tue, 13 Dec 2005 23:07:58 +0200 [thread overview]
Message-ID: <20051213210757.GC6715@mellanox.co.il> (raw)
In-Reply-To: <439D417E.903@yahoo.com.au>
Quoting Nick Piggin <nickpiggin@yahoo.com.au>:
> >
> >>or try to do something tricky with page_count to determine
> >>if we need to do a copy in fork() rather than a COW.
> >
> >
> > I'm actually reasonably happy with the trick that I'm using:
> > performing a second get_user_pages after DMA and comparing
> > the page lists.
> > However, doing this every time on the off chance that a
> > page was made COW forces me into task context, every time.
> >
>
> I think it might be possible to solve it with the early-copy in
> fork(). I'll tinker with it.
A possible way to do this would be adding an option to get_user_pages,
and if selected, setting a flag on all pages in range.
This flag should be cleared in put_page when the reference count drops to 1.
The only thing left would be to do the actual copy if the flag is set.
HTH,
--
MST
prev parent reply other threads:[~2005-12-13 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 19:09 Michael S. Tsirkin
2005-12-08 19:19 ` Hugh Dickins
2005-12-08 19:29 ` Michael S. Tsirkin
2005-12-08 19:54 ` Jens Axboe
2005-12-08 21:56 ` Michael S. Tsirkin
2005-12-12 3:28 ` Nick Piggin
2005-12-12 6:35 ` Michael S. Tsirkin
2005-12-12 7:10 ` Nick Piggin
2005-12-12 8:14 ` Michael S. Tsirkin
2005-12-12 8:32 ` Nick Piggin
2005-12-12 8:55 ` Michael S. Tsirkin
2005-12-12 9:23 ` Nick Piggin
2005-12-12 9:59 ` Michael S. Tsirkin
2005-12-13 21:07 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213210757.GC6715@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pbadari@us.ibm.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®