mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karsten Keil <kkeil@suse.de>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Greg KH <greg@kroah.com>, Hansjoerg Lipp <hjlipp@web.de>,
	Karsten Keil <kkeil@suse.de>,
	linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [linux-usb-devel] [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface
Date: Wed, 14 Dec 2005 13:12:23 +0100	[thread overview]
Message-ID: <20051214121223.GA19325@pingi3.kke.suse.de> (raw)
In-Reply-To: <43A003C0.80207@imap.cc>

On Wed, Dec 14, 2005 at 12:36:32PM +0100, Tilman Schmidt wrote:
> Greg KH wrote:
> > Are there existing userspace tools that rely on proc files for isdn
> > control?  If not, please do not add new proc files, these should be in
> > sysfs instead.
> 
> Thanks for your comment. We'll move everything to sysfs. Most of it is
> done already, but there is a problematic case I'd like your advice on:
> the "info" and "hwinfo" entries, which emit several lines of status
> and statistics information.
> 

To solve this in sysfs, you could create a group (subdir) and there
use a entry with a value for every status item.
Same for statistics info.
See /sys/class/net/<netdevice>/statistics/ as example. 

> According to Documentation/filesystems/sysfs.txt:
> "Mixing types, expressing multiple lines of data, and doing fancy
> formatting of data is heavily frowned upon. Doing these things may get
> you publically humiliated and your code rewritten without notice."
> We certainly don't want to risk that. :-)
> 
> We have tentatively created an entry in /proc/tty/driver/ as proposed
> in LDD3 chapter 18, section "proc and sysfs Handling of TTY Devices"
> as a replacement. But that has the drawback of giving us only a
> single file per driver as opposed to one or two files per device.
> So the driver has to enumerate the devices and concatenate their data,
> which appears cumbersome, even though normal users will probably
> never connect more than one of these devices.
> 
> Is there a better alternative?

See above, I would drop procfs completly.

-- 
Karsten Keil
SuSE Labs
ISDN development

  reply	other threads:[~2005-12-14 12:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-11 18:20 [PATCH 0/9] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Hansjoerg Lipp
2005-12-11 18:20   ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Hansjoerg Lipp
2005-12-11 18:20     ` [PATCH 3/9] isdn4linux: Siemens Gigaset drivers - event layer Hansjoerg Lipp
2005-12-11 18:20       ` [PATCH 4/9] isdn4linux: Siemens Gigaset drivers - isdn4linux interface Hansjoerg Lipp
2005-12-11 18:20         ` [PATCH 5/9] isdn4linux: Siemens Gigaset drivers - tty interface Hansjoerg Lipp
2005-12-11 18:20           ` [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface Hansjoerg Lipp
2005-12-11 18:20             ` [PATCH 7/9] isdn4linux: Siemens Gigaset drivers - direct USB connection Hansjoerg Lipp
2005-12-11 18:20               ` [PATCH 8/9] isdn4linux: Siemens Gigaset drivers - isochronous data handler Hansjoerg Lipp
2005-12-11 18:20                 ` [PATCH 9/9] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter Hansjoerg Lipp
2005-12-11 18:33             ` [linux-usb-devel] [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface Greg KH
2005-12-14 11:36               ` Tilman Schmidt
2005-12-14 12:12                 ` Karsten Keil [this message]
2005-12-12 17:57           ` [PATCH 5/9] isdn4linux: Siemens Gigaset drivers - tty interface Stephen Hemminger
2005-12-12 17:54     ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Stephen Hemminger
2005-12-12 18:02     ` Stephen Hemminger
2005-12-12 17:41 ` [PATCH 0/9] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214121223.GA19325@pingi3.kke.suse.de \
    --to=kkeil@suse.de \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=hjlipp@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®