From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750903AbVLOSOI (ORCPT ); Thu, 15 Dec 2005 13:14:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750894AbVLOSOI (ORCPT ); Thu, 15 Dec 2005 13:14:08 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:16058 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1750827AbVLOSOH (ORCPT ); Thu, 15 Dec 2005 13:14:07 -0500 Date: Thu, 15 Dec 2005 18:14:05 +0000 From: Al Viro To: Geert Uytterhoeven Cc: Roman Zippel , Linus Torvalds , Linux Kernel Development , Linux/m68k Subject: Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration Message-ID: <20051215181405.GB27946@ftp.linux.org.uk> References: <20051215085516.GU27946@ftp.linux.org.uk> <20051215171645.GY27946@ftp.linux.org.uk> <20051215175536.GA27946@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2005 at 07:00:54PM +0100, Geert Uytterhoeven wrote: > Even if behavior is unchanged, this doesn't mean that people like their code > being modified behind their back... > > Anyway, last time I tried to bring this up with the union of Mac and PowerMac > guys, no one seemed to remember why ADBREQ_RAW was really needed... >>From my reading of the code it's a way for mac/misc.c to send a packet that starts with CUDA_PACKET or PMU_PACKET instead of ADB_PACKET, but otherwise is the same as normal adb_request() ones... Used for access to timer, nvram, etc. - looks like that puppy used to use the same protocol for more than just ADB and the first byte of packet really selects the destination...