From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Input: fix an OOPS in HID driver
Date: Sat, 17 Dec 2005 11:22:23 +0100 [thread overview]
Message-ID: <20051217102223.GB27280@midnight.suse.cz> (raw)
In-Reply-To: <200512162131.04544.dtor_core@ameritech.net>
On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> Subject:
>
> This patch fixes an OOPS in HID driver when connecting simulation
> devices generating unknown simulation events.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
might be safer.
> ---
>
> drivers/usb/input/hid-input.c | 1 +
> 1 files changed, 1 insertion(+)
>
> Index: work/drivers/usb/input/hid-input.c
> ===================================================================
> --- work.orig/drivers/usb/input/hid-input.c
> +++ work/drivers/usb/input/hid-input.c
> @@ -137,6 +137,7 @@ static void hidinput_configure_usage(str
> switch (usage->hid & 0xffff) {
> case 0xba: map_abs(ABS_RUDDER); break;
> case 0xbb: map_abs(ABS_THROTTLE); break;
> + default: goto unknown;
> }
> break;
>
>
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-12-17 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-17 2:31 Dmitry Torokhov
2005-12-17 10:22 ` Vojtech Pavlik [this message]
2005-12-17 16:40 ` Dmitry Torokhov
2005-12-17 16:42 ` Dmitry Torokhov
2005-12-22 0:15 ` Adrian Bunk
2005-12-22 4:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051217102223.GB27280@midnight.suse.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®