From: Andrew Morton <akpm@osdl.org>
To: Roland Dreier <rolandd@cisco.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [git patch review 2/7] IB/mthca: correct log2 calculation
Date: Sat, 17 Dec 2005 12:38:16 -0800 [thread overview]
Message-ID: <20051217123816.18ad94e0.akpm@osdl.org> (raw)
In-Reply-To: <1134705617067-bb88e1b23a3e36b6@cisco.com>
Roland Dreier <rolandd@cisco.com> wrote:
>
> Fix thinko in rd_atomic calculation: ffs(x) - 1 does not find the next
> power of 2 -- it should be fls(x - 1).
Please use round_up_pow_of_two().
next prev parent reply other threads:[~2005-12-17 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 4:00 [git patch review 1/7] IB/mthca: check RDMA limits Roland Dreier
2005-12-16 4:00 ` [git patch review 2/7] IB/mthca: correct log2 calculation Roland Dreier
2005-12-16 4:00 ` [git patch review 3/7] IB/mthca: don't change driver's copy of attributes if modify QP fails Roland Dreier
2005-12-16 4:00 ` [git patch review 4/7] IB/mthca: Fix thinko in mthca_table_find() Roland Dreier
2005-12-16 4:00 ` [git patch review 5/7] IB/mthca: Fix SRQ cleanup during QP destroy Roland Dreier
2005-12-16 4:00 ` [git patch review 6/7] IB/mthca: Fix IB_QP_ACCESS_FLAGS handling Roland Dreier
2005-12-16 4:00 ` [git patch review 7/7] IB/mthca: Fix corner cases in max_rd_atomic value handling in modify QP Roland Dreier
2005-12-17 20:38 ` Andrew Morton [this message]
2005-12-17 21:30 ` [git patch review 2/7] IB/mthca: correct log2 calculation Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051217123816.18ad94e0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®