From: Francois Romieu <romieu@fr.zoreil.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
Manfred Spraul <manfred@colorfullife.com>,
Ayaz Abdulla <AAbdulla@nvidia.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: fix random memory scribbling bug
Date: Sat, 24 Dec 2005 22:20:57 +0100 [thread overview]
Message-ID: <20051224212057.GA22117@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <43ADB83A.4090005@pobox.com>
Jeff Garzik <jgarzik@pobox.com> :
[...]
> Paranoia -- the situation above never occurs. It is coded as are other
> drivers: np->rx_buf_sz only changes in ->change_mtu(), which (a) is
> serialized against close and (b) always stops the engine and drains RX
> skbs before changing the size.
Yep.
Btw, regarding the "more sense" thing, now:
- pci_{map/unmap}_single() uses skb->foo
- nv_alloc_rx() and friends use np->rx_buf_sz
(thread moved to netdev@vger.kernel.org)
--
Ueimor
next prev parent reply other threads:[~2005-12-24 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-24 13:19 Manfred Spraul
2005-12-24 15:09 ` Jeff Garzik
2005-12-24 16:08 ` Manfred Spraul
2005-12-24 19:57 ` Linus Torvalds
2005-12-24 19:52 ` Linus Torvalds
2005-12-24 19:56 ` Manfred Spraul
2005-12-24 20:41 ` Linus Torvalds
2005-12-24 21:06 ` Jeff Garzik
2005-12-24 21:20 ` Francois Romieu [this message]
2005-12-24 19:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051224212057.GA22117@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=AAbdulla@nvidia.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®