From: Arnd Bergmann <arnd@arndb.de>
To: Kees Cook <keescook@chromium.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, Jeffy <jeffy.chen@rock-chips.com>,
Simon Horman <horms+renesas@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Magnus Damm <damm+renesas@opensource.se>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: fix atags_to_fdt with stack-protector-strong
Date: Fri, 18 Dec 2015 22:09:12 +0100 [thread overview]
Message-ID: <2005828.pC3KGx5clE@wuerfel> (raw)
In-Reply-To: <20151218210459.GA23293@www.outflux.net>
On Friday 18 December 2015 13:04:59 Kees Cook wrote:
> +ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y)
> +CFLAGS_atags_to_fdt.o := -fno-stack-protector
> +CFLAGS_fdt.o := -fno-stack-protector
> +CFLAGS_fdt_ro.o := -fno-stack-protector
> +CFLAGS_fdt_rw.o := -fno-stack-protector
> +CFLAGS_fdt_wip.o := -fno-stack-protector
> +endif
I'm pretty sure you don't need the ifeq there, you can simply define those
flags unconditionally.
You can't just add -fno-stack-protector unconditionally, because that
breaks building the kernel with toolchains that are older than stack-protector,
so this should be
CFLAGS_obj.o += $(call cc-option, -fno-stack-protector)
Other than that, the patch looks ok.
Arnd
next prev parent reply other threads:[~2015-12-18 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 21:04 Kees Cook
2015-12-18 21:09 ` Arnd Bergmann [this message]
2015-12-18 21:26 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2005828.pC3KGx5clE@wuerfel \
--to=arnd@arndb.de \
--cc=damm+renesas@opensource.se \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=jeffy.chen@rock-chips.com \
--cc=keescook@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®