From: Sam Ravnborg <sam@ravnborg.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Dag-Erling Sm?rgrav <des@linpro.no>
Subject: Re: [PATCH] Avoid namespace pollution in <asm/param.h>
Date: Mon, 2 Jan 2006 19:13:55 +0100 [thread overview]
Message-ID: <20060102181355.GA16324@mars.ravnborg.org> (raw)
In-Reply-To: <200601021702.k02H2mLh015729@hera.kernel.org>
On Mon, Jan 02, 2006 at 09:02:48AM -0800, Linux Kernel Mailing List wrote:
> tree f0d89e7d946a7ed9b57bb29e93bae4ce25d2cbc2
> parent f12f4d90308a22396ac87f6c3a7b2620589614c3
> author Dag-Erling Sm?rgrav <des@linpro.no> Mon, 02 Jan 2006 15:57:06 +0100
> committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 03 Jan 2006 00:38:38 -0800
>
> [PATCH] Avoid namespace pollution in <asm/param.h>
>
> In commit 3D59121003721a8fad11ee72e646fd9d3076b5679c, the x86 and x86-64
> <asm/param.h> was changed to include <linux/config.h> for the
> configurable timer frequency.
config.h is always implicit included using -include option to gcc,
so the
> --- a/include/asm-i386/param.h
> +++ b/include/asm-i386/param.h
> @@ -1,9 +1,8 @@
> -#include <linux/config.h>
is redundant and the correct patch would be to get rid of it.
Same goes for:
> --- a/include/asm-x86_64/param.h
> +++ b/include/asm-x86_64/param.h
> @@ -1,9 +1,8 @@
> -#include <linux/config.h>
Sam
next parent reply other threads:[~2006-01-02 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200601021702.k02H2mLh015729@hera.kernel.org>
2006-01-02 18:13 ` Sam Ravnborg [this message]
2006-01-03 10:47 ` Dag-Erling Smørgrav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060102181355.GA16324@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=des@linpro.no \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®