mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alistair John Strachan <s0348365@sms.ed.ac.uk>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 80 column line limit?
Date: Thu, 5 Jan 2006 23:02:09 +0000	[thread overview]
Message-ID: <200601052302.09317.s0348365@sms.ed.ac.uk> (raw)
In-Reply-To: <20060105130249.GB29894@vrfy.org>

On Thursday 05 January 2006 13:02, Kay Sievers wrote:
> Can't we relax the 80 column line rule to something more comfortable?
> These days descriptive variable/function names are much more valuable,
> I think.
>
> Just by looking at random examples in the tree, seems the 80 column
> rule does more harm than good. I always find myself start shortening
> names just to fit the line limit and not to need to line-wrap a statement.

I've found myself drifting to and from favouring the 80 cols limit in my own 
code. It's a good way of forcing yourself to refactor, which usually works 
out nicely, and I've even managed to write Java that was mostly 80 cols 
(which is a far bigger challenge than C due to the required preceding tab 
depth for a method inside a class..)

> We even use #defines sometimes to access simple structure members and
> the like, only to fit that rule.

This is usually for multiple levels of dereferencing, and it really does help 
readability.

> So, are we sure that 80 columns is still valuable, looking at the
> side-effects of artificially shortended variable/function names and
> line-wrapped statements, caused by this rule?

It's fairly redundant trying to answer this question without the opinion of 
the people that really matter. I'd hazard a guess and say that if you ranked 
kernel contributors by man-hours spent on the kernel, the top ten would all 
think the 80 columns rule was critically important.

-- 
Cheers,
Alistair.

'No sense being pessimistic, it probably wouldn't work anyway.'
Third year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

  parent reply	other threads:[~2006-01-05 23:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-05 13:02 Kay Sievers
2006-01-05 13:27 ` Jesper Juhl
     [not found]   ` <20060105154330.da1016fc.grundig@teleline.es>
2006-01-05 22:27     ` Jesper Juhl
2006-01-05 13:32 ` Pekka Enberg
2006-01-05 21:14   ` Kay Sievers
2006-01-05 22:03     ` Jan Engelhardt
2006-01-06  5:52       ` Willy Tarreau
2006-01-06  7:09         ` Jan Engelhardt
2006-01-05 13:43 ` Giuliano Pochini
2006-01-05 23:02 ` Alistair John Strachan [this message]
2006-01-06  1:34 ` Jim Nance
2006-01-06  7:12   ` Jan Engelhardt
     [not found] <5rD2D-xs-11@gated-at.bofh.it>
2006-01-05 18:08 ` Bodo Eggert
2006-01-06  7:14   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601052302.09317.s0348365@sms.ed.ac.uk \
    --to=s0348365@sms.ed.ac.uk \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®