mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@hpl.hp.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@osdl.org>,
	ak@suse.de
Subject: Re: ptrace denies access to EFLAGS_RF
Date: Fri, 6 Jan 2006 06:02:17 -0800	[thread overview]
Message-ID: <20060106140217.GD7676@frankl.hpl.hp.com> (raw)
In-Reply-To: <200601052314_MC3-1-B55E-CFB5@compuserve.com>

Chuck,

To my surprise, applying the same fix to the x86_64 does not
solve the problem on my Opteron box. I verified that the
offset (144) matches with what the kernel is expecting.
Somehow the RF is lost or not set in the proper location.
I cannot make forward progress once I reach the breakpoint.

Is there something else to on x86_64?

Thanks.

On Thu, Jan 05, 2006 at 11:11:29PM -0500, Chuck Ebbert wrote:
> In-Reply-To: <20060105105130.GC3712@frankl.hpl.hp.com>
> 
> On Thu, 5 Jan 2006 at 02:51:30 -0800, Stephane Eranian wrote:
> 
> > I am trying to the user HW debug registers on i386
> > and I am running into a problem with ptrace() not allowing access
> > to EFLAGS_RF for POKEUSER (see FLAG_MASK).
> > 
> > I am not sure I understand the motivation for denying access
> > to this flag which can be used to resume after a code
> > breakpoint has been reached. It avoids the need to remove the
> > breakpoint, single step, and reinstall. The equivalent
> > functionality exists on IA-64 and is allowed by ptrace().
> 
> I see no reason for denying this.  This patch should fix it:
> 
> 
> i386: PTRACE_POKEUSR: allow changing RF bit in EFLAGS register.
> 
> Setting RF (resume flag) allows a debugger to resume execution
> after a code breakpoint without tripping the breakpoint again.
> It is reset by the CPU after execution of one instruction.
> 
> Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
> 
> --- 2.6.15a.orig/arch/i386/kernel/ptrace.c
> +++ 2.6.15a/arch/i386/kernel/ptrace.c
> @@ -32,9 +32,12 @@
>   * in exit.c or in signal.c.
>   */
>  
> -/* determines which flags the user has access to. */
> -/* 1 = access 0 = no access */
> -#define FLAG_MASK 0x00044dd5
> +/*
> + * Determines which flags the user has access to [1 = access, 0 = no access].
> + * Prohibits changing ID(21), VIP(20), VIF(19), VM(17), IOPL(12-13), IF(9).
> + * Also masks reserved bits (31-22, 15, 5, 3, 1).
> + */
> +#define FLAG_MASK 0x00054dd5
>  
>  /* set's the trap flag. */
>  #define TRAP_FLAG 0x100
> -- 
> Chuck
> Currently reading: _Thud!_ by Terry Pratchett

-- 

-Stephane

  parent reply	other threads:[~2006-01-06 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06  4:11 Chuck Ebbert
2006-01-06  9:39 ` Stephane Eranian
2006-01-06 14:02 ` Stephane Eranian [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-06 16:10 Chuck Ebbert
2006-01-12 22:11 ` Stephane Eranian
2006-01-05 10:51 Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060106140217.GD7676@frankl.hpl.hp.com \
    --to=eranian@hpl.hp.com \
    --cc=76306.1226@compuserve.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®