From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbWAFQ0A (ORCPT ); Fri, 6 Jan 2006 11:26:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752359AbWAFQ0A (ORCPT ); Fri, 6 Jan 2006 11:26:00 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:50443 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1752274AbWAFQZ7 (ORCPT ); Fri, 6 Jan 2006 11:25:59 -0500 Date: Fri, 6 Jan 2006 17:25:54 +0100 From: Adrian Bunk To: adaplas@pol.net Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: drivers/video/imsttfb.c: setclkMHz: clk_p is always 0 Message-ID: <20060106162554.GJ12131@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The Coverity checker noticed that in the function setclkMHz in drivers/video/imsttfb.c, the variable clk_p is never assigned a value other than 0. Could someone understanding this code decide whether this is a real bug or whether clk_p can be replaced by 0? TIA Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed