From: Petr Vandrovec <petr@vmware.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Pass proper device from BusLogic to SCSI layer
Date: Sat, 7 Jan 2006 05:25:47 +0100 [thread overview]
Message-ID: <20060107042547.GA4255@vana.vc.cvut.cz> (raw)
Hi Andrew,
While trying to get SUSE's SLES9 working on system with more than 4GB
we've noticed that SCSI layer happilly passes addresses over 4GB to
the buslogic driver, which is quite a big problem as buslogic can
generate only 32bit busmastering cycles.
Fortunately in the current kernels this problem does not exist anymore
as SCSI layer now assumes 4GB capable device by default, but it is
still good idea to pass correct device structure to the SCSI layer.
If nothing else, /sys/block/sda/device now points to
/sys/devices/pci0000:00/0000:00:10.0/host0/... instead of
/sys/devices/platform/host0/... like it did in the past.
Change does nothing for ISA based BusLogic adapters, they'll still
end under platform (and they are probably broken for long time as
I do not see anything forcing ISA 16MB limit for them).
Thanks,
Petr Vandrovec
diff -urdN linux/drivers/scsi/BusLogic.c linux/drivers/scsi/BusLogic.c
--- linux/drivers/scsi/BusLogic.c 2006-01-01 16:22:50.000000000 +0100
+++ linux/drivers/scsi/BusLogic.c 2006-01-01 16:34:43.000000000 +0100
@@ -2216,6 +2216,7 @@
HostAdapter->PCI_Address = ProbeInfo->PCI_Address;
HostAdapter->Bus = ProbeInfo->Bus;
HostAdapter->Device = ProbeInfo->Device;
+ HostAdapter->PCI_Device = ProbeInfo->PCI_Device;
HostAdapter->IRQ_Channel = ProbeInfo->IRQ_Channel;
HostAdapter->AddressCount = BusLogic_HostAdapterAddressCount[HostAdapter->HostAdapterType];
/*
@@ -2296,7 +2297,7 @@
scsi_host_put(Host);
} else {
BusLogic_InitializeHostStructure(HostAdapter, Host);
- scsi_add_host(Host, NULL);
+ scsi_add_host(Host, HostAdapter->PCI_Device ? &HostAdapter->PCI_Device->dev : NULL);
scsi_scan_host(Host);
BusLogicHostAdapterCount++;
}
reply other threads:[~2006-01-07 4:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060107042547.GA4255@vana.vc.cvut.cz \
--to=petr@vmware.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®