From: Kyle McMartin <kyle@parisc-linux.org>
To: akpm@osdl.org
Cc: linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
parisc-linux@lists.parisc-linux.org, carlos@parisc-linux.org,
willy@parisc-linux.org
Subject: [PATCH 5/5] Decrapify evdev.c of per-arch compat hacks
Date: Sun, 8 Jan 2006 14:38:11 -0500 [thread overview]
Message-ID: <20060108193811.GL3782@tachyon.int.mcmartin.ca> (raw)
From: Kyle McMartin <kyle@parisc-linux.org>
A nice cleanup of evdev.c by using the is_compat_task() macro.
Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
---
drivers/input/evdev.c | 18 +++---------------
1 files changed, 3 insertions(+), 15 deletions(-)
3e7a8822763c01f93afdb2f0011dec6b641df1fb
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index f7490a0..3cabb4b 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -154,27 +154,15 @@ struct input_event_compat {
__s32 value;
};
-#ifdef CONFIG_X86_64
-# define COMPAT_TEST test_thread_flag(TIF_IA32)
-#elif defined(CONFIG_IA64)
-# define COMPAT_TEST IS_IA32_PROCESS(ia64_task_regs(current))
-#elif defined(CONFIG_S390)
-# define COMPAT_TEST test_thread_flag(TIF_31BIT)
-#elif defined(CONFIG_MIPS)
-# define COMPAT_TEST (current->thread.mflags & MF_32BIT_ADDR)
-#else
-# define COMPAT_TEST test_thread_flag(TIF_32BIT)
-#endif
-
static inline size_t evdev_event_size(void)
{
- return COMPAT_TEST ?
+ return is_compat_task(current) ?
sizeof(struct input_event_compat) : sizeof(struct input_event);
}
static int evdev_event_from_user(const char __user *buffer, struct input_event *event)
{
- if (COMPAT_TEST) {
+ if (is_compat_task(current)) {
struct input_event_compat compat_event;
if (copy_from_user(&compat_event, buffer, sizeof(struct input_event_compat)))
@@ -196,7 +184,7 @@ static int evdev_event_from_user(const c
static int evdev_event_to_user(char __user *buffer, const struct input_event *event)
{
- if (COMPAT_TEST) {
+ if (is_compat_task(current)) {
struct input_event_compat compat_event;
compat_event.time.tv_sec = event->time.tv_sec;
--
1.0.7
next reply other threads:[~2006-01-08 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 19:38 Kyle McMartin [this message]
2006-01-08 20:16 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060108193811.GL3782@tachyon.int.mcmartin.ca \
--to=kyle@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=carlos@parisc-linux.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=willy@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®