From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernelrelase only recomputed when necessary
Date: Sun, 8 Jan 2006 22:01:27 +0100 [thread overview]
Message-ID: <20060108210127.GA8545@mars.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0601081250441.3169@g5.osdl.org>
On Sun, Jan 08, 2006 at 12:51:37PM -0800, Linus Torvalds wrote:
> This part looks bogus:
>
> > diff --git a/arch/x86_64/Makefile b/arch/x86_64/Makefile
> > index a9cd42e..663dbdb 100644
> > --- a/arch/x86_64/Makefile
> > +++ b/arch/x86_64/Makefile
> > @@ -80,7 +80,7 @@ bzlilo: vmlinux
> > bzdisk: vmlinux
> > $(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) zdisk
> >
> > -install fdimage fdimage144 fdimage288: vmlinux
> > +install fdimage fdimage144 fdimage288:
> > $(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) $@
> >
> > archclean:
>
>
> That rule should probably be:
>
> fdimage fdimage144 fdimage288: vmlinux
> install:
> $(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) $@
>
> since the fdimages should still depend on vmlinux.
>
> No?
I failed to apply the path from hpa before starting on the
kernelrelesase stuff - so what you see above was just a
quick hack allowing me to test "make install" and should have been
deleted before I sent out the mail - sorry.
hpa already do the right thing in his patch - similar to what you
suggest.
Sam
prev parent reply other threads:[~2006-01-08 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 20:37 Sam Ravnborg
2006-01-08 20:51 ` Linus Torvalds
2006-01-08 21:01 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060108210127.GA8545@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®