From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] RTC subsystem, sysfs interface
Date: Mon, 9 Jan 2006 03:13:39 +0100 [thread overview]
Message-ID: <20060109031339.6c661d9c@inspiron> (raw)
In-Reply-To: <200601082102.40992.dtor_core@ameritech.net>
On Sun, 8 Jan 2006 21:02:40 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> On Sunday 08 January 2006 18:12, Alessandro Zummo wrote:
> > +static ssize_t rtc_sysfs_show_date(struct class_device *dev, char *buf)
> > +{
> > + ssize_t retval = -ENODEV;
> > + struct rtc_device *rtc = to_rtc_device(dev);
> > + struct rtc_time tm;
[...]
> ops locking is a mess here. Half of the code accesses it under protection
> of ops_lock while other half is unlocked. I think it would be better if
> that lock was taken in rtc_read_time and friends.
Good point. I'll move them, thanks.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
next prev parent reply other threads:[~2006-01-09 2:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 23:12 [PATCH 0/8] RTC subsystem Alessandro Zummo
2006-01-08 23:12 ` [PATCH 1/8] RTC subsystem, class Alessandro Zummo
2006-01-08 23:12 ` [PATCH 2/8] RTC subsystem, ARM cleanup Alessandro Zummo
2006-01-08 23:12 ` [PATCH 3/8] RTC subsystem, sysfs interface Alessandro Zummo
[not found] ` <200601082102.40992.dtor_core@ameritech.net>
2006-01-09 2:13 ` Alessandro Zummo [this message]
2006-01-08 23:12 ` [PATCH 4/8] RTC subsystem, proc interface Alessandro Zummo
[not found] ` <200601082056.30227.dtor_core@ameritech.net>
2006-01-09 2:04 ` Alessandro Zummo
2006-01-09 2:50 ` Dmitry Torokhov
2006-01-08 23:12 ` [PATCH 5/8] RTC subsystem, dev interface Alessandro Zummo
2006-01-09 2:50 ` Dmitry Torokhov
2006-01-09 3:12 ` Alessandro Zummo
2006-01-09 6:39 ` Dmitry Torokhov
2006-01-09 9:14 ` Alessandro Zummo
2006-01-08 23:12 ` [PATCH 6/8] RTC subsystem, X1205 driver Alessandro Zummo
2006-01-08 23:12 ` [PATCH 7/8] RTC subsystem, test device/driver Alessandro Zummo
2006-01-08 23:12 ` [PATCH 8/8] RTC subsystem, DS1672 driver Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060109031339.6c661d9c@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®