From: Sam Ravnborg <sam@ravnborg.org>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>,
Ryan Anderson <ryan@michonline.com>,
linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Use git in scripts/setlocalversion
Date: Mon, 9 Jan 2006 06:58:50 +0100 [thread overview]
Message-ID: <20060109055850.GA8011@mars.ravnborg.org> (raw)
In-Reply-To: <2cd57c900601081947l24598adm@mail.gmail.com>
On Mon, Jan 09, 2006 at 11:47:12AM +0800, Coywolf Qi Hunt wrote:
> 2006/1/5, Rene Scharfe <rene.scharfe@lsrfire.ath.cx>:
> > Currently scripts/setlocalversion is a Perl script that tries to figure
> > out the current git commit ID of a repo without using git. It also
> > imports Digest::MD5 without using it and generally is too big for the
> > small task it does. :] And it always reports a git ID, even when the
> > HEAD is tagged -- this is a bug.
> >
> > This patch replaces it with a Bourne Shell script that uses git
> > commands to do the same. I can't come up with a scenario where someone
> > would use a git repo and refuse to install git core at the same time,
> > so I think it's reasonable to assume git is available.
> You didn't update the caller in the top Makefile, but that's ok.
It's fixed in my tree.
Sam
prev parent reply other threads:[~2006-01-09 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 19:42 Rene Scharfe
2006-01-04 22:43 ` Ryan Anderson
2006-01-06 19:47 ` Sam Ravnborg
2006-01-08 9:35 ` [PATCH] setlocalversion: Change -git_dirty to just -dirty Ryan Anderson
2006-01-08 17:45 ` Sam Ravnborg
2006-01-09 3:47 ` [PATCH] Use git in scripts/setlocalversion Coywolf Qi Hunt
2006-01-09 5:58 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060109055850.GA8011@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=coywolf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=ryan@michonline.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome