From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-xfs@oss.sgi.com
Subject: Re: xfs: Makefile-linux-2.6 => Makefile?
Date: Mon, 9 Jan 2006 18:19:38 +0100 [thread overview]
Message-ID: <20060109171938.GA19283@mars.ravnborg.org> (raw)
In-Reply-To: <20060109164611.GA1382@infradead.org>
On Mon, Jan 09, 2006 at 04:46:11PM +0000, Christoph Hellwig wrote:
> On Mon, Jan 09, 2006 at 05:42:14PM +0100, Sam Ravnborg wrote:
> > Hi hch.
> >
> > Any specific reason why xfs uses a indirection for the Makefile?
> > It is planned to drop export of VERSION, PATCHLEVEL etc. from
> > main makefile and it is OK except for xfs due to the funny
> > Makefile indirection.
> >
> > I suggest:
> > git mv fs/xfs/Makefile-linux-2.6 fs/xfs/Makefile
>
> I'd be all for it, but the SGI people like this layout to keep a common
> fs/xfs for both 2.4 and 2.6 (with linux-2.4 and linux-2.6 subdirs respectively)
>
I have the following in my tree right now to make it compile.
But it looks pointless to me. All other submitters are asked to keep
backward compatibility cruft out of kernel proper - the same should
hold for xfs.
Sam
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index 49e3e7e..0630339 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -1 +1 @@
-include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
+include $(srctree)/fs/xfs/Makefile-linux-2.6
next prev parent reply other threads:[~2006-01-09 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 16:42 Sam Ravnborg
2006-01-09 16:46 ` Christoph Hellwig
2006-01-09 17:19 ` Sam Ravnborg [this message]
2006-01-09 21:01 ` Sam Ravnborg
2006-01-09 21:05 ` Christoph Hellwig
2006-01-09 21:18 ` Sam Ravnborg
2006-01-09 21:03 ` Eric Sandeen
2006-01-09 21:20 ` Sam Ravnborg
2006-01-09 21:23 ` Eric Sandeen
2006-01-09 21:45 ` Sam Ravnborg
2006-01-10 7:45 ` Andrew Morton
2006-01-10 15:14 ` Eric Sandeen
2006-01-10 16:34 ` Eric Sandeen
2006-01-10 20:02 ` Sam Ravnborg
2006-01-16 23:19 ` Sam Ravnborg
2006-01-17 3:40 ` Eric Sandeen
2006-01-10 20:00 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060109171938.GA19283@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®