From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030205AbWAIRZ6 (ORCPT ); Mon, 9 Jan 2006 12:25:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030203AbWAIRZ6 (ORCPT ); Mon, 9 Jan 2006 12:25:58 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:24980 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964883AbWAIRZ5 (ORCPT ); Mon, 9 Jan 2006 12:25:57 -0500 Date: Mon, 9 Jan 2006 17:25:54 +0000 From: Christoph Hellwig To: Jeff Mahoney Cc: linux-ia64@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] ia64: including alone causes compilation errors Message-ID: <20060109172554.GA3026@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeff Mahoney , linux-ia64@vger.kernel.org, Linux Kernel Mailing List References: <20060109171514.GA25096@locomotive.unixthugs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060109171514.GA25096@locomotive.unixthugs.org> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote: > > Including *just* on ia64 will result in a compilation failure, > where it will succeed on every other architecture. > > Every other arch includes either directly or via > at the top of . ia64 includes > after including , which causes > the __user in to get passed through untouched, causing > compilation errors. > > This patch moves the #include up to the beginning of signal.h, > as found on every other arch. > > A specific example of where this behavior is observed is the recent addition > of OCFS2. fs/ocfs2/cluster/userdlm.c seems alone in only including > , which seems to be perfectly valid. Generally you should only include via , which gets via