From: Vivek Goyal <vgoyal@in.ibm.com>
To: Morton Andrew Morton <akpm@osdl.org>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
linuxppc64-dev@ozlabs.org,
Fastboot mailing list <fastboot@lists.osdl.org>
Subject: [PATCH] kdump: vmcore compilation warning fix
Date: Tue, 10 Jan 2006 12:34:22 +0530 [thread overview]
Message-ID: <20060110070422.GB5003@in.ibm.com> (raw)
o fs/proc/vmcore.c compilation gives warnings on ppc64. The reason being
that u64 is defined as unsigned long hence u64* is not same as loff_t*
and compiler cribs.
o Changed the parameter type to u64* instead of loff_t* to resolve the
conflict.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
diff -puN fs/proc/vmcore.c~ppc64-vmcore-compilation-warning-fix fs/proc/vmcore.c
--- linux-2.6.15-mm2-1M/fs/proc/vmcore.c~ppc64-vmcore-compilation-warning-fix 2006-01-09 06:59:06.000000000 -0800
+++ linux-2.6.15-mm2-1M-root/fs/proc/vmcore.c 2006-01-09 07:37:06.000000000 -0800
@@ -42,7 +42,7 @@ struct proc_dir_entry *proc_vmcore = NUL
/* Reads a page from the oldmem device from given offset. */
static ssize_t read_from_oldmem(char *buf, size_t count,
- loff_t *ppos, int userbuf)
+ u64 *ppos, int userbuf)
{
unsigned long pfn, offset;
size_t nr_bytes;
_
reply other threads:[~2006-01-10 7:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110070422.GB5003@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=akpm@osdl.org \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®