Re: [parisc-linux] [PATCH 1/5] Add generic compat_siginfo_t

[Kyle McMartin <kyle@parisc-linux.org>]

On Mon, Jan 09, 2006 at 03:13:55PM +0100, Christoph Hellwig wrote:
> -mm already has a much better implementation for compat_sys_timer_create
> that doesn't require all the sigevent churn in this patch (which btw
> doesn't seem to be mentioned in the changelog at all).  

Ok, I see it in -mm now, and it does seem to be nicer code, I'll
try it out on parisc64.

> But even with
> that remove there seems to be a lot of useless ifdef and indirection
> in this patch.  

I agree, I'm really just trying to shepard this home so we don't have
to maintain it out of tree. I'm not overly attached to the code, if
I can make parisc64 work with your compat signal bits, I'll be
just as happy.

The one thing from this patchset I'd like to keep is the is_compat_task()
as it does provide nice cleanups 

Cheers, Kyle

> Over the next days I'll send out my generic compat
> singal bits which don't require all this, but otoh require every
> architecture to supply helpers.  If you can make those generic without
> all the ifdef an additional header bits all power to you!