From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix running 'make kernelrelease' before builing
Date: Tue, 10 Jan 2006 21:00:16 +0100 [thread overview]
Message-ID: <20060110200016.GA13461@lsrfire.ath.cx> (raw)
Hi Sam,
after your latest Makefile changes 'make kernelrelease' displays an
empty line when it is run before building. I think it's more useful
to let it build the kernel version and display it.
The patch makes kernelrelease dependant on .kernelrelease. It also
moves one echo call to the single other place that depends on
.kernelrelease. Otherwise it would display its message there _and_
when called through 'make kernelrelease'.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
diff --git a/Makefile b/Makefile
index deedaf7..403eee0 100644
--- a/Makefile
+++ b/Makefile
@@ -788,7 +788,6 @@ kernelrelease = \
.kernelrelease: FORCE
$(Q)rm -f .kernelrelease
$(Q)echo $(kernelrelease) > .kernelrelease
- $(Q)echo " Building kernel $(kernelrelease)"
# Things we need to do before we recursively start building the kernel
@@ -808,6 +807,7 @@ kernelrelease = \
# 1) Check that make has not been executed in the kernel src $(srctree)
# 2) Create the include2 directory, used for the second asm symlink
prepare3: .kernelrelease
+ $(Q)echo " Building kernel $(KERNELRELEASE)"
ifneq ($(KBUILD_SRC),)
@echo ' Using $(srctree) as source for kernel'
$(Q)if [ -f $(srctree)/.config ]; then \
@@ -1300,7 +1300,7 @@ checkstack:
$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
$(PERL) $(src)/scripts/checkstack.pl $(ARCH)
-kernelrelease:
+kernelrelease: .kernelrelease
@echo $(KERNELRELEASE)
kernelversion:
@echo $(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)
reply other threads:[~2006-01-10 20:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110200016.GA13461@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome