From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: cpw@sgi.com, linux-kernel@vger.kernel.org, clameter@sgi.com,
lhms-devel@lists.sourceforge.net, taka@valinux.co.jp,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH 5/5] Direct Migration V9: Avoid writeback / page_migrate() method
Date: Tue, 10 Jan 2006 22:03:14 -0800 [thread overview]
Message-ID: <20060110220314.70e5793b.akpm@osdl.org> (raw)
In-Reply-To: <20060110224140.19138.84122.sendpatchset@schroedinger.engr.sgi.com>
Christoph Lameter <clameter@sgi.com> wrote:
>
> + spin_lock(&mapping->private_lock);
> +
> + bh = head;
> + do {
> + get_bh(bh);
> + lock_buffer(bh);
> + bh = bh->b_this_page;
> +
> + } while (bh != head);
> +
Guys, lock_buffer() sleeps and cannot be called inside spinlock.
Please, always enable kernel preemption and all debug options when testing
your code.
next prev parent reply other threads:[~2006-01-11 6:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 22:41 [PATCH 0/5] Direct Migration V9: Overview Christoph Lameter
2006-01-10 22:41 ` [PATCH 1/5] Direct Migration V9: PageSwapCache checks Christoph Lameter
2006-01-10 22:41 ` [PATCH 2/5] Direct Migration V9: migrate_pages() extension Christoph Lameter
2006-01-11 5:46 ` Andrew Morton
2006-01-12 3:25 ` Christoph Lameter
2006-01-10 22:41 ` [PATCH 3/5] Direct Migration V9: remove_from_swap() to remove swap ptes Christoph Lameter
2006-01-10 22:41 ` [PATCH 4/5] Direct Migration V9: upgrade MPOL_MF_MOVE and sys_migrate_pages() Christoph Lameter
2006-01-10 22:41 ` [PATCH 5/5] Direct Migration V9: Avoid writeback / page_migrate() method Christoph Lameter
2006-01-11 6:03 ` Andrew Morton [this message]
2006-01-11 6:38 ` Christoph Lameter
2006-01-11 6:49 ` Andrew Morton
2006-01-11 6:52 ` Christoph Lameter
2006-01-11 6:25 ` Andrew Morton
2006-01-11 3:26 ` [PATCH 0/5] Direct Migration V9: Overview KAMEZAWA Hiroyuki
2006-01-11 6:10 ` Christoph Lameter
2006-01-11 6:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110220314.70e5793b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=cpw@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome