From: Andrew Morton <akpm@osdl.org>
To: mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org,
video4linux-list@redhat.com, xslaby@fi.muni.cz,
jirislaby@gmail.com, mchehab@infradead.org
Subject: Re: [PATCH 09/20] V4L/DVB (3344d) Stradis video little cleanup
Date: Wed, 11 Jan 2006 19:53:40 -0800 [thread overview]
Message-ID: <20060111195340.0b74967c.akpm@osdl.org> (raw)
In-Reply-To: <20060112025553.PS72536800009@infradead.org>
mchehab@infradead.org wrote:
>
> +errosd:
> + vfree(saa->osdbuf);
> + saa->osdbuf = NULL;
> +erraud:
> + vfree(saa->audbuf);
> + saa->audbuf = NULL;
> +errvid:
> + vfree(saa->vidbuf);
> + saa->vidbuf = NULL;
> +err:
> + return -ENOMEM;
> }
vfree(NULL) is legal, so this could be:
error:
vfree(saa->osdbuf);
vfree(saa->audbuf);
vfree(saa->vidbuf);
saa->vidbuf = NULL;
saa->osdbuf = NULL;
saa->audbuf = NULL;
next prev parent reply other threads:[~2006-01-12 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060112025516.PS38541900000@infradead.org>
[not found] ` <20060112025552.PS20388000005@infradead.org>
2006-01-12 3:51 ` [PATCH 05/20] V4L/DVB (3343) Add support for DViCO FusionHDTV DVB-T USB devices Andrew Morton
[not found] ` <20060112025553.PS72536800009@infradead.org>
2006-01-12 3:53 ` Andrew Morton [this message]
[not found] ` <20060112025557.PS14543900013@infradead.org>
2006-01-12 3:54 ` [PATCH 13/20] V4L/DVB (3345) Fixes some bad global variables Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111195340.0b74967c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jirislaby@gmail.com \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®