From: Chuck Ebbert <76306.1226@compuserve.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch] kobject: don't oops on null kobject.name
Date: Thu, 12 Jan 2006 20:02:00 -0500 [thread overview]
Message-ID: <200601122004_MC3-1-B5C5-4B72@compuserve.com> (raw)
kobject_get_path() will oops if one of the component names is
NULL. Fix that by returning NULL instead of oopsing.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
---
Helge, this fixes your "2.6.15 OOPS while trying to mount cdrom".
Probably not the best fix, but It Works For Me (TM).
--- 2.6.15a.orig/lib/kobject.c
+++ 2.6.15a/lib/kobject.c
@@ -72,6 +72,8 @@ static int get_kobj_path_length(struct k
* Add 1 to strlen for leading '/' of each level.
*/
do {
+ if (kobject_name(parent) == NULL)
+ return 0;
length += strlen(kobject_name(parent)) + 1;
parent = parent->parent;
} while (parent);
@@ -107,6 +109,8 @@ char *kobject_get_path(struct kobject *k
int len;
len = get_kobj_path_length(kobj);
+ if (len == 0)
+ return NULL;
path = kmalloc(len, gfp_mask);
if (!path)
return NULL;
--
Chuck
Currently reading: _Olympos_ by Dan Simmons
next reply other threads:[~2006-01-13 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 1:02 Chuck Ebbert [this message]
2006-01-13 22:30 ` Andrew Morton
2006-01-13 22:55 ` Greg KH
2006-01-13 23:12 ` Andrew Morton
2006-01-14 0:02 ` Greg KH
2006-01-14 3:07 Chuck Ebbert
2006-01-14 3:07 Chuck Ebbert
2006-01-14 3:44 ` Greg KH
2006-01-14 16:18 Chuck Ebbert
2006-02-06 20:29 [PATCH] SPI: spi_butterfly, restore lost deltas Greg KH
2006-02-06 20:29 ` [PATCH] kobject: don't oops on null kobject.name Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601122004_MC3-1-B5C5-4B72@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome