From: Denis Vlasenko <vda@ilport.com.ua>
To: Chris Wedgwood <cw@f00f.org>
Cc: "Bryan O'Sullivan" <bos@pathscale.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org, hch@infradead.org,
ak@suse.de, rdreier@cisco.com
Subject: Re: [PATCH 2 of 3] memcpy32 for x86_64
Date: Fri, 13 Jan 2006 12:24:36 +0200 [thread overview]
Message-ID: <200601131224.36545.vda@ilport.com.ua> (raw)
In-Reply-To: <20060113095625.GA3707@taniwha.stupidest.org>
On Friday 13 January 2006 11:56, Chris Wedgwood wrote:
> On Thu, Jan 12, 2006 at 08:04:41AM -0800, Bryan O'Sullivan wrote:
>
> > This is true for 64-bit writes over Hypertransport
>
> is this something that will always be or just something current
> hardware does?
Yes, why risking that things will go wrong?
Also you'll get shorter code. Instead of
> + .globl memcpy32
> +memcpy32:
> + movl %edx,%ecx
> + shrl $1,%ecx
> + andl $1,%edx
> + rep movsq
> + movl %edx,%ecx
> + rep movsd
> + ret
you need just
.globl memcpy32
memcpy32:
movl %edx,%ecx
rep movsd
ret
With properly written inlined asms code will be
reduced to just "rep movsd".
--
vda
next prev parent reply other threads:[~2006-01-13 10:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 19:53 [PATCH 0 of 3] 32-bit MMIO copy routines, reworked Bryan O'Sullivan
2006-01-10 19:53 ` [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-10 19:53 ` [PATCH 2 of 3] memcpy32 for x86_64 Bryan O'Sullivan
2006-01-12 8:38 ` Denis Vlasenko
2006-01-12 16:04 ` Bryan O'Sullivan
2006-01-13 9:56 ` Chris Wedgwood
2006-01-13 10:24 ` Denis Vlasenko [this message]
2006-01-13 16:21 ` Bryan O'Sullivan
2006-01-10 19:53 ` [PATCH 3 of 3] Add __raw_memcpy_toio32 to each arch Bryan O'Sullivan
2006-01-10 20:08 ` Andi Kleen
2006-01-10 22:52 ` Bryan O'Sullivan
-- strict thread matches above, loose matches on Subject: below --
2006-01-11 22:39 [PATCH 0 of 3] MMIO 32-bit copy routine, the final frontier Bryan O'Sullivan
2006-01-11 22:39 ` [PATCH 2 of 3] memcpy32 for x86_64 Bryan O'Sullivan
2006-01-11 23:45 ` Roland Dreier
2006-01-12 0:03 ` Bryan O'Sullivan
2006-01-06 20:26 [PATCH 0 of 3] 32-bit MMIO copy routine Bryan O'Sullivan
2006-01-06 20:26 ` [PATCH 2 of 3] memcpy32 for x86_64 Bryan O'Sullivan
2005-12-27 23:41 [PATCH 0 of 3] Add memcpy_toio32, a 32-bit MMIO copy routine Bryan O'Sullivan
2005-12-27 23:41 ` [PATCH 2 of 3] memcpy32 for x86_64 Bryan O'Sullivan
2005-12-28 4:22 ` Matt Mackall
2005-12-28 7:54 ` Denis Vlasenko
2005-12-28 14:52 ` Bryan O'Sullivan
2006-01-06 9:12 ` Pavel Machek
2006-01-06 16:02 ` Bryan O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601131224.36545.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=cw@f00f.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome