From: Anton Blanchard <anton@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, rolandd@cisco.com
Subject: Re: [patch 2.6.15-mm4] sem2mutex: infiniband, #2
Date: Sun, 15 Jan 2006 12:59:10 +1100 [thread overview]
Message-ID: <20060115015910.GK26421@krispykreme> (raw)
In-Reply-To: <20060114150949.GA24284@elte.hu>
Hi Ingo,
Just a small thing, it looks like the script is doing a double include
of linux/mutex.h a few times:
> Index: linux/drivers/infiniband/hw/mthca/mthca_dev.h
> ===================================================================
> --- linux.orig/drivers/infiniband/hw/mthca/mthca_dev.h
> +++ linux/drivers/infiniband/hw/mthca/mthca_dev.h
> @@ -44,7 +44,9 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/timer.h>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
> +#include <linux/mutex.h>
> +
>
> #include "mthca_provider.h"
> #include "mthca_doorbell.h"
...
> Index: linux/drivers/infiniband/hw/mthca/mthca_memfree.h
> ===================================================================
> --- linux.orig/drivers/infiniband/hw/mthca/mthca_memfree.h
> +++ linux/drivers/infiniband/hw/mthca/mthca_memfree.h
> @@ -40,7 +40,9 @@
> #include <linux/list.h>
> #include <linux/pci.h>
>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
> +#include <linux/mutex.h>
> +
>
> #define MTHCA_ICM_CHUNK_LEN \
> ((256 - sizeof (struct list_head) - 2 * sizeof (int)) / \
Anton
next prev parent reply other threads:[~2006-01-15 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 15:09 Ingo Molnar
2006-01-15 1:59 ` Anton Blanchard [this message]
2006-01-15 4:48 ` Ingo Molnar
2006-01-15 4:46 ` Horst von Brand
2006-01-30 23:17 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060115015910.GK26421@krispykreme \
--to=anton@samba.org \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome