mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>,
	linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>
Subject: Re: [patch 2.6.15-mm4] sem2mutex: I2C, #2
Date: Mon, 16 Jan 2006 21:39:17 +0100	[thread overview]
Message-ID: <20060116213917.361e40f6.khali@linux-fr.org> (raw)
In-Reply-To: <20060114162527.GA4822@elte.hu>

Hi Ingo,

> semaphore to mutex conversion.
> 
> the conversion was generated via scripts, and the result was validated
> automatically via a script as well.
> 
> build tested.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ----
> 
>  drivers/i2c/busses/i2c-amd756-s4882.c |   14 ++++++-----
>  drivers/i2c/busses/i2c-isa.c          |    2 -
>  drivers/i2c/chips/eeprom.c            |    9 +++----
>  drivers/i2c/chips/max6875.c           |   10 +++----
>  drivers/i2c/chips/pcf8591.c           |   13 +++++-----
>  drivers/i2c/chips/tps65010.c          |   43 +++++++++++++++++-----------------
>  drivers/i2c/i2c-core.c                |   34 +++++++++++++-------------
>  include/linux/i2c.h                   |    6 ++--
>  8 files changed, 68 insertions(+), 63 deletions(-)

drivers/i2c/chips/tps65010.c looks broken to me: you updated every use
of the lock, but the structure itself is still declared as a semaphore.
I'll fix it up.

Also, any reason why drivers/i2c/busses/scx200_acb.c was not converted?
I'll convert it unless you had a specific reason no to.

Thanks,
-- 
Jean Delvare

      reply	other threads:[~2006-01-16 20:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-14 16:25 Ingo Molnar
2006-01-16 20:39 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060116213917.361e40f6.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®