mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <npiggin@suse.de>
Cc: jack@suse.cz, npiggin@suse.de, linux-kernel@vger.kernel.org
Subject: Re: unmount oops in log_do_checkpoint
Date: Tue, 17 Jan 2006 03:46:01 -0800	[thread overview]
Message-ID: <20060117034601.6556322a.akpm@osdl.org> (raw)
In-Reply-To: <20060117113727.GB24083@wotan.suse.de>

Nick Piggin <npiggin@suse.de> wrote:
>
> On Mon, Jan 16, 2006 at 10:22:50PM +0100, Jan Kara wrote:
> > > 2.6.15-git12 (and 11, not sure when it started) oops when unmounting
> > > an ext3 filesystem. Looks like 'transaction' in log_do_checkpoint is
> > > garbage.
> > > 
> 
> [oops]
> 
> >   It would be useful to find out which patch cause it (by git bisect)
> > but one obvious suspect is my merged ext3 patch to checkpoint.c. I'll
> > investigate tomorrow.
> > 
> 
> Yep, reverting jbd split checkpoint lists in -git12 fixes it. It is
> 100% reproducible so far, and every time rebooting with a patched
> kernel fails to result in the oops.
> 

But that patch was in -mm for months.  How come you didn't hit the oops
earlier?  One would almost expect some odd patch interaction, but changes
in ext3 have been small for a long time.

  reply	other threads:[~2006-01-17 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-16 16:04 Nick Piggin
2006-01-16 21:22 ` Jan Kara
2006-01-17 11:37   ` Nick Piggin
2006-01-17 11:46     ` Andrew Morton [this message]
2006-01-17 11:59       ` Nick Piggin
2006-01-17 14:09         ` Nick Piggin
2006-01-17 16:32           ` Jan Kara
2006-01-17 16:36             ` Nick Piggin
2006-01-17 22:23               ` Jan Kara
2006-01-18  5:41                 ` Nick Piggin
2006-01-18 10:35                   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117034601.6556322a.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®