From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: PATCH: Fix warning on 64bit boxes
Date: Tue, 17 Jan 2006 12:43:14 -0800 [thread overview]
Message-ID: <20060117124314.26823ae7.zaitcev@redhat.com> (raw)
In-Reply-To: <1137520565.14135.45.camel@localhost.localdomain>
On Tue, 17 Jan 2006 17:56:05 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> We cast an int to a void * which not unreasonably makes gcc suspicious.
> We don't actually care what type "type" is so use unsigned long so it
> matches pointer length on all platforms.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
> static int usu_probe(struct usb_interface *intf,
> const struct usb_device_id *id)
> {
> - int type;
> + unsigned long type;
Looks good to me.
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
-- Pete
prev parent reply other threads:[~2006-01-17 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:56 Alan Cox
2006-01-17 20:43 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117124314.26823ae7.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®