From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, bboissin@gmail.com, xslaby@fi.muni.cz,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Iptables error
Date: Sat, 21 Jan 2006 12:05:53 +0100 [thread overview]
Message-ID: <20060121110553.GS4603@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20060120.114613.54096131.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Fri, Jan 20, 2006 at 11:46:13AM -0800, David S. Miller wrote:
> Your struct won't be 8-byte aligned either as far as I can tell on
> x86_64.
According to my tests, the struct is 8-byte-aligned on x86_64, and
that's how I'd like it to be.
Please don't ask me why it happens, I know that the alignment constraint
of a u64 on x86_64 is only 4. But at least gcc-3.3.6 and gcc-4.0.3
(debian) result in __alignof__ of that test structure (and a 'u_int64_t
alone') to 8 bytes.
When it comes to these things, I can only do trial+error.
Maybe it's because __alignof__ returns the recommended alignment, not
the required alignment.
> We need to use the aligned_u64 thing if you want that.
That should make sure that we always get what we want, yes.
--
- Harald Welte <laforge@netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-01-21 11:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 11:15 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:33 ` 2.6.16-rc1-mm2 Pekka Enberg
2006-01-20 11:40 ` 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:56 ` 2.6.16-rc1-mm2 Pekka J Enberg
2006-01-20 15:19 ` 2.6.16-rc1-mm2 Valdis.Kletnieks
2006-01-20 13:58 ` [PATCH] zone_reclaim cpus_empty needs a real variable Andy Whitcroft
2006-01-20 16:28 ` Christoph Lameter
2006-01-20 21:34 ` Andrew Morton
2006-01-20 14:05 ` 2.6.16-rc1-mm2 Dave Jones
2006-01-20 16:23 ` Iptables error [Was: 2.6.16-rc1-mm2] Jiri Slaby
2006-01-20 16:36 ` Harald Welte
2006-01-20 16:41 ` Jiri Slaby
2006-01-20 16:43 ` Benoit Boissinot
2006-01-20 16:49 ` Linus Torvalds
2006-01-20 16:58 ` Benoit Boissinot
2006-01-20 17:38 ` Benoit Boissinot
2006-01-20 16:59 ` Jiri Slaby
2006-01-20 17:02 ` Jiri Slaby
2006-01-20 17:11 ` Carlos Silva
2006-01-20 19:32 ` Harald Welte
2006-01-20 19:46 ` Iptables error David S. Miller
2006-01-21 11:05 ` Harald Welte [this message]
2006-01-20 20:02 ` David S. Miller
2006-01-23 2:03 ` Iptables error [Was: 2.6.16-rc1-mm2] Herbert Xu
2006-01-23 2:23 ` Keith Owens
2006-01-23 20:53 ` Eric W. Biederman
2006-01-20 18:13 ` Valdis.Kletnieks
2006-01-20 19:52 ` Iptables error David S. Miller
2006-01-20 21:26 ` 2.6.16-rc1-mm2: arch/arm26/kernel/fiq.c still doesn't compile Adrian Bunk
2006-01-20 21:57 ` Alexey Dobriyan
2006-01-20 23:22 ` 2.6.16-rc1-mm2 Reuben Farrelly
2006-01-21 15:14 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 16:39 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 18:45 ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-21 21:36 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 23:57 ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-23 12:39 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-27 14:53 ` 2.6.16-rc1-mm2 Jeff Garzik
[not found] ` <200601280846.23279.edt@aei.ca>
2006-02-04 23:43 ` 2.6.16-rc1-mm2 (mm5 too) panics Ed Tomlinson
2006-02-24 1:57 ` 2.6.16-rc4-mm1 & " Ed Tomlinson
2006-01-24 3:51 ` 2.6.16-rc1-mm2 Neil Brown
2006-01-23 18:41 ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 18:47 ` 2.6.16-rc1-mm2 Christoph Lameter
2006-01-23 19:32 ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 19:39 ` 2.6.16-rc1-mm2 Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121110553.GS4603@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=akpm@osdl.org \
--cc=bboissin@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®