From: Tejun Heo <htejun@gmail.com>
To: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: [PATCH] BLOCK: use disk_stat_add instead of __disk_stat_add in __end_that_request_first
Date: Sun, 22 Jan 2006 02:22:33 +0900 [thread overview]
Message-ID: <20060121172233.GA18239@htj.dyndns.org> (raw)
Unlike end_that_request_last, caller is supposed to own the request
when it calls __end_that_request_first and thus allowed to call from
any context without any locking. When SCSI EH completes requests, it
calls __end_that_request_first from kernel thread context without
holding any lock and none of preemption/bh/irq disabled. This results
in the following warning.
BUG: using smp_processor_id() in preemptible [00000001] code: scsi_eh_6/927
caller is __end_that_request_first+0xbf/0x500
[<c01046e3>] show_trace+0x13/0x20
[<c010470e>] dump_stack+0x1e/0x20
[<c02231c8>] debug_smp_processor_id+0xa8/0xb0
[<c021167f>] __end_that_request_first+0xbf/0x500
[<c0211ad1>] end_that_request_chunk+0x11/0x20
[<c03360b2>] scsi_end_request+0x32/0x110
-- snip --
This patch makes __end_that_request_first() use undashed
disk_stat_add() which doesn't assume preemption is disabled.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index 8e27d0a..eb0473b 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -3153,7 +3153,7 @@ static int __end_that_request_first(stru
if (blk_fs_request(req) && req->rq_disk) {
const int rw = rq_data_dir(req);
- __disk_stat_add(req->rq_disk, sectors[rw], nr_bytes >> 9);
+ disk_stat_add(req->rq_disk, sectors[rw], nr_bytes >> 9);
}
total_bytes = bio_nbytes = 0;
next reply other threads:[~2006-01-21 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 17:22 Tejun Heo [this message]
2006-01-21 19:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121172233.GA18239@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome