From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>, Greg KH <greg@kroah.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: 2.6.16-rc1-mm2
Date: Sun, 22 Jan 2006 00:08:29 -0500 [thread overview]
Message-ID: <200601220010_MC3-1-B666-7037@compuserve.com> (raw)
gregkh-pci-msi-vector-targeting-abstractions.patch breaks msi on x86_64:
In file included from include/asm/msi.h:11,
from drivers/pci/msi.h:9,
from drivers/pci/msi-apic.c:15:
include/asm/smp.h:103: error: syntax error before ‘->’ token
include/asm-x86_64/msi.h:#include <asm/mach_apic.h>
include/asm-x86_64/mach_apic.h:#define cpu_mask_to_apicid (genapic->cpu_mask_to_apicid)
include/asm-x86_64/smp.h:103:static inline unsigned int cpu_mask_to_apicid(cpumask_t cpumask)
drivers/pci/msi.c does not have this problem because it includes <asm/smp.h>
_before_ "msi.h" so the #define overrides the inline function.
Ugly patch to fix this follows... at least it compiles now...
Fix msi on x86_64, broken due to include-ordering problems.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
drivers/pci/msi-apic.c | 2 ++
1 files changed, 2 insertions(+)
--- 2.6.16-rc1-mm2.orig/drivers/pci/msi-apic.c
+++ 2.6.16-rc1-mm2/drivers/pci/msi-apic.c
@@ -11,6 +11,8 @@
#include <linux/pci.h>
#include <linux/irq.h>
+#include <asm/smp.h>
+
#include "pci.h"
#include "msi.h"
--
Chuck
next reply other threads:[~2006-01-22 5:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 5:08 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-22 14:18 2.6.16-rc1-mm2 Chuck Ebbert
2006-01-20 11:15 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:33 ` 2.6.16-rc1-mm2 Pekka Enberg
2006-01-20 11:40 ` 2.6.16-rc1-mm2 Andrew Morton
2006-01-20 11:56 ` 2.6.16-rc1-mm2 Pekka J Enberg
2006-01-20 15:19 ` 2.6.16-rc1-mm2 Valdis.Kletnieks
2006-01-20 14:05 ` 2.6.16-rc1-mm2 Dave Jones
2006-01-20 23:22 ` 2.6.16-rc1-mm2 Reuben Farrelly
2006-01-21 15:14 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 16:39 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 18:45 ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-21 21:36 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-21 23:57 ` 2.6.16-rc1-mm2 Barry K. Nathan
2006-01-23 12:39 ` 2.6.16-rc1-mm2 Ed Tomlinson
2006-01-27 14:53 ` 2.6.16-rc1-mm2 Jeff Garzik
2006-01-24 3:51 ` 2.6.16-rc1-mm2 Neil Brown
2006-01-23 18:41 ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 18:47 ` 2.6.16-rc1-mm2 Christoph Lameter
2006-01-23 19:32 ` 2.6.16-rc1-mm2 Serge E. Hallyn
2006-01-23 19:39 ` 2.6.16-rc1-mm2 Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601220010_MC3-1-B666-7037@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome